ContinuousWavelet: add tests for dtype and remove unused **kwargs #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ContinuousWavelet
object allows specifying single or double precision via a dtype argument. This seems to work as expected, although is undocumented. This PR documents thisdtype
parameter and adds tests for it. I also removed an unused**kwargs
parameter from the__cinit__
.Finally, this adds validation during wavelet creation to give a clear error when specifying an unsupported
dtype
. Prior to this PR the wavelet can be created with unsupported dtypes, but then when trying to use it viawavefun
orintegrate_wavelet
, one would get errors like: