Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace camera image with a CC0-licensed equivalent #572

Merged
merged 2 commits into from Oct 13, 2020

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Oct 11, 2020

This is an image taken by Lav Varshney in the same location as the original. This one has a CC0 license.

See more details in the discussion at scikit-image/scikit-image#3927

Fortunately, for PyWavelets this only involved needing to update a single test case. The image is used in the landing page of our docs, but I think the new one also looks fine there as-is.

closes #500

@grlee77 grlee77 added this to the v1.2 milestone Oct 11, 2020
@grlee77 grlee77 changed the title Replace camera Replace camera image with a CC0-licensed equivalent Oct 11, 2020
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment on author name

pywt/data/_readers.py Show resolved Hide resolved
@grlee77
Copy link
Contributor Author

grlee77 commented Oct 12, 2020

The CI failure seen here was resolved by #573 so this is now ready.

@rgommers rgommers merged commit 2c44a67 into PyWavelets:master Oct 13, 2020
@rgommers
Copy link
Member

Merged, thanks @grlee77!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace cameraman image due to an uncertain rights
3 participants