Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update pyproject.toml and setup.py for Python 3.10 #604

Merged
merged 1 commit into from Nov 8, 2021

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Nov 6, 2021

Also remove setup_requires from setup.py. This is no longer needed,'
removing it avoids using easy_install. The role that setup_requires
used to play is now played by pyproject.toml. This change was made
in SciPy quite a while ago, so it's safe by now.

gh-603 adds CI support for Python 3.10. Also, conda-forge/pywavelets-feedstock#42 aims to build a 3.10 conda-forge package. So I think we're due for a new release here.

Also remove `setup_requires` from `setup.py`. This is no longer needed,'
removing it avoids using `easy_install`. The role that `setup_requires`
used to play is now played by `pyproject.toml`. This change was made
in SciPy quite a while ago, so it's safe by now.
@rgommers rgommers added this to the v1.2 milestone Nov 6, 2021
@rgommers rgommers requested a review from grlee77 November 6, 2021 17:58
@rgommers
Copy link
Member Author

rgommers commented Nov 6, 2021

So I think we're due for a new release here.

I've tested on macOS arm64 as well, all tests pass. @grlee77 shall we merge this, merge the other two PRs (assuming they pass), then tag v1.2.0?

Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @rgommers!

@grlee77 grlee77 merged commit 2ea90a5 into PyWavelets:master Nov 8, 2021
@grlee77
Copy link
Contributor

grlee77 commented Nov 8, 2021

I've tested on macOS arm64 as well, all tests pass. @grlee77 shall we merge this, merge the other two PRs (assuming they pass), then tag v1.2.0?

Please check the small update in #393 and merge it if it looks good. Then I think we are ready to tag v1.2.0. We are also hoping to tag a new scikit-image release later this week and it should help to have Python 3.10 PyWavelets wheels for that.

I made a new PR to build wheels for 3.10 here (#610)

@rgommers
Copy link
Member Author

rgommers commented Nov 8, 2021

Okay, everything is merged! Do you want to do the release @grlee77, or do you want me to? I think all we need now is adding release notes and a commit with the version number change. Then push the tag, and the bot will do its magic? A twine token for PyPI is present already, so wheels and sdist should just appear on PyPI.

@grlee77
Copy link
Contributor

grlee77 commented Nov 8, 2021

I can make the release later today.

@grlee77
Copy link
Contributor

grlee77 commented Nov 8, 2021

Actually it looks like merging the MRA PR broke readthedocs again, but I can fix that before release.

@rgommers
Copy link
Member Author

rgommers commented Nov 8, 2021

Actually it looks like merging the MRA PR broke readthedocs again, but I can fix that before release.

I fixed that already, the last build passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants