Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 wheels for Python 3.7 and fix manylinux versions #626

Merged
merged 5 commits into from
Mar 3, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Mar 2, 2022

closes #625

aside from adding aarch64 for Python 3.7 this makes a few other changes:

1.) update to use manylinux2014 in most cases except for Python 3.7 or the i686 wheels (matching what NumPy provides). These are also the manylinux versions we used in the scikit-image 0.19.x releases.

2.) adds PIP_PREFER_BINARY=1 flag so that a binary wheel version of NumPy will always be preferred during testing. This avoids potentially building NumPy or SciPy from source if a wheel is missing (e.g. most recent releases dropped Python 3.7)

3.) I added CIBW_SKIP: "*-musllinux_*" to skip all musllinux wheels, but I can revert that change if preferred.

@grlee77
Copy link
Contributor Author

grlee77 commented Mar 2, 2022

I ran the wheel building process for this in #625 (comment) and have only added the naming update in af24d86 since that time

@rgommers
Copy link
Member

rgommers commented Mar 3, 2022

This avoids potentially building NumPy or SciPy from source if a wheel is missing (e.g. most recent releases dropped Python 3.7)

Did you actually see this happening? That would be a bug in the sdist metadata, python_requires>=3.8 should prevent this kind of trigger of a source build.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @grlee77! I agree with all the choices you made.

CI is all green, except for AppVeyor which I think we can ignore. So in it goes.

@rgommers rgommers merged commit 0374d9f into PyWavelets:v1.2.x Mar 3, 2022
@rgommers
Copy link
Member

rgommers commented Mar 3, 2022

Should we make either a 1.3.0 or a 1.2.1 release for this?

@grlee77
Copy link
Contributor Author

grlee77 commented Mar 3, 2022

Should we make either a 1.3.0 or a 1.2.1 release for this?

I was initially planning to tag it as 1.2.1, but perhaps 1.3.0 is better given that we changed which wheels are provided?

@grlee77
Copy link
Contributor Author

grlee77 commented Mar 3, 2022

This avoids potentially building NumPy or SciPy from source if a wheel is missing (e.g. most recent releases dropped Python 3.7)

Did you actually see this happening? That would be a bug in the sdist metadata, python_requires>=3.8 should prevent this kind of trigger of a source build.

In an early commit I saw this failure:
https://github.com/grlee77/pywt/runs/5385058094?check_suite_focus=true
That was prior to adding that prefer binary flag, but was also when it was still set to manylinux1. I could run it again just removing that flag from the final version here.

@rgommers
Copy link
Member

rgommers commented Mar 3, 2022

I was initially planning to tag it as 1.2.1, but perhaps 1.3.0 is better given that we changed which wheels are provided?

1.3.0 sounds good to me.

I could run it again just removing that flag from the final version here.

No worries, thanks for pointing me at the older failure - that should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants