-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aarch64 wheels for Python 3.7 and fix manylinux versions #626
Conversation
i686 stays on manylinux2010 to match numpy1.17.3
I ran the wheel building process for this in #625 (comment) and have only added the naming update in af24d86 since that time |
Did you actually see this happening? That would be a bug in the sdist metadata, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @grlee77! I agree with all the choices you made.
CI is all green, except for AppVeyor which I think we can ignore. So in it goes.
Should we make either a 1.3.0 or a 1.2.1 release for this? |
I was initially planning to tag it as 1.2.1, but perhaps 1.3.0 is better given that we changed which wheels are provided? |
In an early commit I saw this failure: |
1.3.0 sounds good to me.
No worries, thanks for pointing me at the older failure - that should be enough. |
closes #625
aside from adding
aarch64
for Python 3.7 this makes a few other changes:1.) update to use manylinux2014 in most cases except for Python 3.7 or the i686 wheels (matching what NumPy provides). These are also the manylinux versions we used in the scikit-image 0.19.x releases.
2.) adds PIP_PREFER_BINARY=1 flag so that a binary wheel version of NumPy will always be preferred during testing. This avoids potentially building NumPy or SciPy from source if a wheel is missing (e.g. most recent releases dropped Python 3.7)
3.) I added
CIBW_SKIP: "*-musllinux_*"
to skip allmusllinux
wheels, but I can revert that change if preferred.