MAINT: use numpy-config and fix support for numpy 2.0
#723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was moved to the `numpy.exceptions` namespace in 1.25.0, and removed from the main namespace in 2.0
rgommers
force-pushed
the
fix-numpy2-support
branch
from
db1352e
to
9ab7dac
Compare
|
Okay, this is happy in CI and works locally with numpy 2.0.0b1, so let's give it a go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we do have a job that installs numpy with
--pre, but 2.0.0b1 gets uninstalled again becausematplotlib(also used/needed in CI jobs) doesn't support it yet.