Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with datetime objects and strings #88

Merged
merged 1 commit into from May 17, 2017

Conversation

meatballs
Copy link
Member

No description provided.

@drvinceknight
Copy link
Collaborator

Is the bug here that we were writing them as date time objects but the way we do this is to only take strings as inputs? (Just checking I understand :))

@meatballs
Copy link
Member Author

Yep. That was exactly the problem. If you pass the events and slots lists from the howto into the scheduler, it all falls over!

@drvinceknight drvinceknight merged commit 668e10b into master May 17, 2017
@meatballs
Copy link
Member Author

I may have a look at doing that datetime stuff in a smarter fashion but at least for now, it's correct!

@drvinceknight
Copy link
Collaborator

I may have a look at doing that datetime stuff in a smarter fashion but at least for now, it's correct!

Instead of a string we could take a datetime as input (so the way you had it here would be correct)? That makes things simpler on the library's side? The user just needs to create the datetime objects?

@meatballs
Copy link
Member Author

I think so, but part of me was reluctant to go to version 3.0.0 just for that. silly really

@meatballs meatballs deleted the define_conference branch May 17, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants