Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: localization guide #59

Merged
merged 1 commit into from
Mar 23, 2022
Merged

chore: localization guide #59

merged 1 commit into from
Mar 23, 2022
+72 −10

Conversation

jab416171
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Mar 22, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pycord-development/guide/5Lhg8r1kUAJCBuLuwieceDtp6wcK
✅ Preview: https://guide-git-fork-jab416171-master-pycord-development.vercel.app

@vercel vercel bot temporarily deployed to Preview March 22, 2022 16:38 Inactive
EmreTech
EmreTech suggested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@EmreTech EmreTech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide needs more explanation. You can't just throw examples around and expect people to understand this.
Also, this should be placed in the Interactions folder, not a new folder.

@EmreTech EmreTech changed the title chore: add docs for localization chore: localization guide Mar 22, 2022
@EmreTech EmreTech added this to the Initial Release milestone Mar 22, 2022
@EmreTech EmreTech mentioned this pull request Mar 22, 2022
Open
35 tasks
@vercel vercel bot temporarily deployed to Preview March 22, 2022 23:52 Inactive
@jab416171
Copy link
Contributor Author

This guide needs more explanation. You can't just throw examples around and expect people to understand this. Also, this should be placed in the Interactions folder, not a new folder.

I added more to the top but please let me know if there's anything specific I should add or mention.

@vercel vercel bot temporarily deployed to Preview March 22, 2022 23:53 Inactive
@vercel vercel bot temporarily deployed to Preview March 22, 2022 23:54 Inactive
EmreTech
EmreTech suggested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@EmreTech EmreTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better, but you should really relocate the localization/index.mdx file to interactions/localization.mdx instead of just changing the sidebar to seem that that is the case.

@vercel vercel bot temporarily deployed to Preview March 23, 2022 00:01 Inactive
@vercel vercel bot temporarily deployed to Preview March 23, 2022 00:05 Inactive
@jab416171 jab416171 requested a review from EmreTech March 23, 2022 00:25
EmreTech
EmreTech approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@EmreTech EmreTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmreTech EmreTech merged commit 6237f2e into Pycord-Development:master Mar 23, 2022
@EmreTech EmreTech mentioned this pull request Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmreTech EmreTech EmreTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Initial Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jab416171 @EmreTech