Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ext.menus to ext.pages, fix docs and typing #589

Merged
merged 7 commits into from
Dec 20, 2021
Merged

Rename ext.menus to ext.pages, fix docs and typing #589

merged 7 commits into from
Dec 20, 2021

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Dec 20, 2021 •
edited
Loading

Summary

PR for the following fixes:

  • Rename to ext.pages to avoid conflicts with the older ext.menus from discord.py
  • Docs, typing fixes

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@VincentRPS VincentRPS mentioned this pull request Dec 20, 2021
Merged
@krittick krittick mentioned this pull request Dec 20, 2021
Closed
7 tasks
@krittick krittick changed the title [WIP] ext.menus updates Rename ext.menus to ext.pages, fix docs and typing Dec 20, 2021
@krittick krittick marked this pull request as ready for review December 20, 2021 15:40
Dorukyum
Dorukyum requested changes Dec 20, 2021
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing rename

examples/views/paginator.py Outdated Show resolved Hide resolved
@krittick
Copy link
Contributor Author

Missing rename

Already fixed :)

@Dorukyum Dorukyum merged commit dec0676 into Pycord-Development:master Dec 20, 2021
@Swhistler1
Copy link

Makes me nervous! My life here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krittick @Swhistler1 @Lulalaby @Dorukyum