Raise TypeError if component custom_id type is not str
#1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krittick
added
priority: low
|
|
Dorukyum
previously requested changes
Feb 15, 2022
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
BobDotCom
previously requested changes
Feb 15, 2022
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
UP929312
reviewed
Feb 15, 2022
UP929312
reviewed
Feb 15, 2022
UP929312
reviewed
Feb 15, 2022
…_ instead of type(custom_id).__name__
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
Middledot
approved these changes
Feb 20, 2022
Dorukyum
approved these changes
Feb 20, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change raises a TypeError if a user provides a
custom_idfor a component (Button, Select, InputText, or Modal) that is notstr.While
custom_idis already type hinted tostr, this change enforces it as a requirement instead of the current behavior where the interaction silently fails.Closes #1010
Checklist
type: ignorecomments were used, a comment is also left explaining why