Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom_id attribute to Interaction #1040

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Add custom_id attribute to Interaction #1040

merged 1 commit into from
Feb 17, 2022

Conversation

BobDotCom
Copy link
Member

Summary

Adds a custom_id attribute to Interaction.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom added priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature Merge normally labels Feb 17, 2022
@BobDotCom BobDotCom added this to the v2.0 milestone Feb 17, 2022
@BobDotCom BobDotCom self-assigned this Feb 17, 2022
@BobDotCom BobDotCom added this to In progress in v2.0 via automation Feb 17, 2022
@BobDotCom BobDotCom merged commit b7f96f1 into master Feb 17, 2022
v2.0 automation moved this from In progress to Done Feb 17, 2022
@Lulalaby Lulalaby deleted the interaction-custom-id branch February 17, 2022 21:09
unrealintegers added a commit to unrealintegers/pycord that referenced this pull request Feb 25, 2022
@unrealintegers
Fix custom_id field
1ceaeb3 
Pycord-Development#1040 added a custom_id field to interactions, however it is accessed wrongly causing it to always be None.
@unrealintegers unrealintegers mentioned this pull request Feb 25, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@krittick krittick Awaiting requested review from krittick

Assignees

@BobDotCom BobDotCom

Labels
feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: No status
v2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BobDotCom @Lulalaby @ChickenDevs