Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord.ext.bridge #1131

Merged
merged 66 commits into from Apr 9, 2022
Merged

discord.ext.bridge #1131

merged 66 commits into from Apr 9, 2022

Conversation

BobDotCom
Copy link
Member

@BobDotCom BobDotCom commented Mar 7, 2022 •
edited

Summary

Adds compatibility between discord.commands and ext.commands.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue. Fixes Add support between application commands and normal commands in commands.Bot #451
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom added priority: medium Medium Priority status: in progress Work in Progess feature Implements a feature Merge with squash labels Mar 7, 2022
@BobDotCom BobDotCom added this to the v2.0 milestone Mar 7, 2022
@BobDotCom BobDotCom self-assigned this Mar 7, 2022
@BobDotCom BobDotCom added this to In progress in v2.0 via automation Mar 7, 2022
@plun1331
Copy link
Member

plun1331 commented Mar 7, 2022 •
edited

I feel like compat isn't a great name for this, it's a bit vague and doesn't really make the purpose of the extension obvious.

@krittick
Copy link
Contributor

krittick commented Mar 7, 2022

I feel like compat isn't a great name for this

Same. Maybe ext.bridge or something?

@27Saumya
Copy link
Contributor

27Saumya commented Mar 8, 2022

@krittick great.. bridge is nice

BobDotCom and others added 9 commits March 26, 2022 14:09
@BobDotCom
Merge branch 'master' into ext-compat
2c4c6bf
@BobDotCom
Fix bridge option choice conversion
36032ef
@BobDotCom
Search for choice names as well
087267b
@BobDotCom
Merge branch 'master' into ext-compat
222b5fb
@BobDotCom
Rename BridgeOption
88d0552
@BobDotCom
Add example
1478a20
@EmreTech @Dorukyum
feat: add ext.bridge docs (#1222)
42d68f6 
* feat: add ext.bridge docs

* chore: requested changes

* Update docs/ext/bridge/index.rst

Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>

Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Dorukyum
Merge branch 'master' into ext-compat
d978558
@BobDotCom
Merge branch 'master' into ext-compat
89c4c07
@BobDotCom BobDotCom marked this pull request as ready for review April 2, 2022 22:40
@BobDotCom BobDotCom enabled auto-merge (squash) April 2, 2022 22:40
@BobDotCom BobDotCom added status: awaiting review Awaiting review from a maintainer and removed status: in progress Work in Progess labels Apr 3, 2022
EmreTech
EmreTech previously approved these changes Apr 3, 2022
View reviewed changes
Dorukyum
Dorukyum approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BobDotCom BobDotCom merged commit a30f76d into master Apr 9, 2022
v2.0 automation moved this from In progress to Done Apr 9, 2022
@Lulalaby Lulalaby deleted the ext-compat branch April 9, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krittick krittick krittick approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@EmreTech EmreTech EmreTech left review comments

@Middledot Middledot Awaiting requested review from Middledot

Assignees

@EmreTech EmreTech

@BobDotCom BobDotCom

Labels
feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: No status
v2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add support between application commands and normal commands in commands.Bot
7 participants
@BobDotCom @plun1331 @krittick @27Saumya @EmreTech @Dorukyum @VincentRPS