Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow type checkers to treat cached_property as a normal property. #1188

Merged
merged 3 commits into from Mar 23, 2022
Merged

Conversation

tsigma6
Copy link
Contributor

@tsigma6 tsigma6 commented Mar 20, 2022

Summary

Using NewType to alias cached_property as a subclass of property allows type checkers to actually treat it as a property instead of a function object without causing the issue that actually sub-classing property would cause.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom enabled auto-merge (squash) March 21, 2022 17:03
@BobDotCom BobDotCom merged commit 1a6054a into Pycord-Development:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants