Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bot.py #1235

Merged
merged 1 commit into from Apr 8, 2022
Merged

Update bot.py #1235

merged 1 commit into from Apr 8, 2022

Conversation

JC-Chung
Copy link
Contributor

@JC-Chung JC-Chung commented Apr 8, 2022 •
edited

Summary

  • UserCommand will get AttributeError when check cmd.description_localizations

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@JC-Chung
Update bot.py
d455e79 
`UserCommand` will get `AttributeError` when check `cmd.description_localizations`
@Dorukyum
Copy link
Member

Dorukyum commented Apr 8, 2022

I can reproduce this but I'm not sure if this is the best solution.

@Dorukyum Dorukyum added the bug Something isn't working label Apr 8, 2022
krittick
krittick approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@krittick krittick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krittick krittick added this to the v2.0 milestone Apr 8, 2022
@krittick krittick enabled auto-merge (squash) April 8, 2022 22:36
@krittick krittick merged commit 3a4f0da into Pycord-Development:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krittick krittick krittick approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@Middledot Middledot Awaiting requested review from Middledot

Assignees
No one assigned
Labels
bug Something isn't working priority: high High Priority
Projects
Pycord Releases
Status: No status
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JC-Chung @Dorukyum @krittick @Lulalaby