Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ext.pages] Compatibility patch for ext.bridge #1288

Merged
merged 3 commits into from Apr 24, 2022
Merged

[ext.pages] Compatibility patch for ext.bridge #1288

merged 3 commits into from Apr 24, 2022

Conversation

krittick
Copy link
Contributor

Summary

This adds compatibility for ext.pages when used with ext.bridge by allowing a BridgeContext object to be passed instead of an Interaction in Paginator.respond().
If a BridgeContext object is passed, Paginator.respond() uses the ext.bridge methods to send the paginated message instead of the Interaction methods.

Due to BridgeContext.respond() not recognizing the ephemeral keyword, paginators passing a BridgeContext object cannot be ephemeral and that parameter will be ignored.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: high High Priority status: awaiting review Awaiting review from a maintainer Merge with squash labels Apr 24, 2022
@krittick krittick added this to the v2.0 milestone Apr 24, 2022
@krittick krittick self-assigned this Apr 24, 2022
@krittick krittick added this to In progress in v2.0 via automation Apr 24, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) April 24, 2022 13:32
@Lulalaby Lulalaby merged commit 8b0d230 into Pycord-Development:master Apr 24, 2022
v2.0 automation moved this from In progress to Done Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
No open projects
v2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants