Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary call to sync_commands #1563

Merged
merged 1 commit into from Aug 12, 2022
Merged

Avoid unnecessary call to sync_commands #1563

merged 1 commit into from Aug 12, 2022

Conversation

BobDotCom
Copy link
Member

Summary

Fixes #1561

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom added bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer Merge with squash labels Aug 12, 2022
@BobDotCom BobDotCom added this to the v2.1 milestone Aug 12, 2022
@BobDotCom BobDotCom self-assigned this Aug 12, 2022
@BobDotCom BobDotCom linked an issue Aug 12, 2022 that may be closed by this pull request
Registered commands not recognized without sync_commands call #1561
Closed
3 tasks
@BobDotCom BobDotCom enabled auto-merge (squash) August 12, 2022 16:07
@BobDotCom BobDotCom requested review from Lulalaby and Dorukyum and removed request for Lulalaby August 12, 2022 16:07
Lulalaby
Lulalaby approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj

@BobDotCom BobDotCom merged commit 99b08d2 into master Aug 12, 2022
@Dorukyum Dorukyum deleted the 1561-registered-commands-not-recognized-without-sync_commands-call branch August 12, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees

@BobDotCom BobDotCom

Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

Registered commands not recognized without sync_commands call
3 participants
@BobDotCom @Lulalaby @Dorukyum