Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Guild Feature INVITES_DISABLED #1613

Merged
merged 8 commits into from
Sep 6, 2022

Conversation

martinbndr
Copy link
Contributor

@martinbndr martinbndr commented Sep 1, 2022

Added new guild feature "INVITES_DISABLED" to the docs description.

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

Added new guild feature "INVITES_DISABLED" to the docs description.
@Lulalaby
Copy link
Member

Lulalaby commented Sep 1, 2022

Could you implement the api method too? Otherwise this pr is kinda useless

Adds: discord.Guild() ``invites_disabled`` property and disable_invites parameter to discord.Guild.edit() to enable/disable guild invites
@martinbndr
Copy link
Contributor Author

martinbndr commented Sep 4, 2022

@Lulalaby Btw sry if there is sth bad, I´m at the beginning of developing in python libaries like this :) But I guess it should be good (it works).

Sry I fogot changing sth for the docs, should be good now I guess
Lulalaby
Lulalaby previously approved these changes Sep 4, 2022
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you

@Lulalaby Lulalaby enabled auto-merge (squash) September 4, 2022 20:00
discord/guild.py Outdated Show resolved Hide resolved
auto-merge was automatically disabled September 4, 2022 20:54

Head branch was pushed to by a user without write access

@martinbndr martinbndr requested review from Lulalaby and removed request for plun1331 September 4, 2022 21:59
Just forgot that ``rules_channel`` and ``public_updates_channel`` needs to be set back to None if ``commuity`` set to False
Lulalaby
Lulalaby previously approved these changes Sep 4, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) September 4, 2022 22:54
discord/guild.py Outdated Show resolved Hide resolved
Co-authored-by: Chicc <chicc@induo.dev>
@Lulalaby Lulalaby enabled auto-merge (squash) September 6, 2022 07:18
@Lulalaby Lulalaby enabled auto-merge (squash) September 6, 2022 07:19
@Lulalaby Lulalaby merged commit d616545 into Pycord-Development:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants