Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Complete forum channel implementation #1636

Merged
merged 56 commits into from Nov 17, 2022
Merged

feat: Complete forum channel implementation #1636

merged 56 commits into from Nov 17, 2022

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Sep 15, 2022

Summary

Closes #1635.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Dorukyum Dorukyum added priority: high High Priority status: in progress Work in Progess feature Implements a feature labels Sep 15, 2022
@Dorukyum Dorukyum added this to the v2.2 milestone Sep 15, 2022
discord/types/channel.py Outdated Show resolved Hide resolved
@Lulalaby Lulalaby self-requested a review September 15, 2022 14:09
@Dorukyum
Copy link
Member Author

I've added the applied_tags field to create_thread and available_tags attribute to _TextChannel as a list of integers since there's no ForumTag class as of now. Thread.edit must be completed and a ForumTag class should probably be created.
CC @BobDotCom

@BobDotCom BobDotCom modified the milestones: v2.2, v2.3 Sep 30, 2022
@Lulalaby
Copy link
Member

ping pong conflicts and needs works
high prio

discord/http.py Outdated Show resolved Hide resolved
discord/http.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1636 (70a9814) into master (8660f67) will increase coverage by 0.06%.
The diff coverage is 42.53%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1636      +/-   ##
==========================================
+ Coverage   33.15%   33.21%   +0.06%     
==========================================
  Files          96       96              
  Lines       18536    18653     +117     
==========================================
+ Hits         6145     6196      +51     
- Misses      12391    12457      +66     
Flag Coverage Δ
macos-latest-3.10 33.20% <42.53%> (+0.06%) ⬆️
macos-latest-3.11 33.20% <42.53%> (+0.06%) ⬆️
macos-latest-3.8 33.21% <42.53%> (+0.06%) ⬆️
macos-latest-3.9 33.21% <42.53%> (+0.06%) ⬆️
ubuntu-latest-3.10 33.20% <42.53%> (+0.06%) ⬆️
ubuntu-latest-3.11 33.20% <42.53%> (+0.06%) ⬆️
ubuntu-latest-3.8 33.21% <42.53%> (+0.06%) ⬆️
ubuntu-latest-3.9 33.21% <42.53%> (+0.06%) ⬆️
windows-latest-3.10 33.20% <42.53%> (+0.06%) ⬆️
windows-latest-3.11 33.20% <42.53%> (+0.06%) ⬆️
windows-latest-3.8 33.21% <42.53%> (+0.06%) ⬆️
windows-latest-3.9 33.21% <42.53%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/abc.py 22.33% <0.00%> (-0.50%) ⬇️
discord/http.py 22.98% <0.00%> (-0.06%) ⬇️
discord/threads.py 30.18% <21.42%> (-0.45%) ⬇️
discord/partial_emoji.py 40.40% <22.22%> (-0.65%) ⬇️
discord/channel.py 34.66% <34.84%> (-0.18%) ⬇️
discord/enums.py 78.71% <80.00%> (+0.01%) ⬆️
discord/flags.py 75.92% <100.00%> (+0.17%) ⬆️
discord/types/channel.py 100.00% <100.00%> (ø)
discord/types/threads.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8660f67...70a9814. Read the comment docs.

BobDotCom
BobDotCom previously approved these changes Nov 15, 2022
@BobDotCom BobDotCom enabled auto-merge (squash) November 15, 2022 17:19
@Lulalaby Lulalaby enabled auto-merge (squash) November 17, 2022 03:33
@BobDotCom BobDotCom merged commit 1ef4bbe into master Nov 17, 2022
@BobDotCom BobDotCom deleted the forum-tags branch November 17, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature priority: high High Priority status: in progress Work in Progess
Projects
Status: Done
4 participants