Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc restyle #1697

Merged
merged 31 commits into from Oct 18, 2022
Merged

Doc restyle #1697

merged 31 commits into from Oct 18, 2022

Conversation

BobDotCom
Copy link
Member

Summary

A complete restyling of the docs. Another implementation was started on the doc-restyle branch, but this version received better feedback from users.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom added documentation Improvements or additions to documentation priority: medium Medium Priority status: in progress Work in Progess labels Oct 11, 2022
@BobDotCom BobDotCom self-assigned this Oct 11, 2022
@BobDotCom BobDotCom force-pushed the doc-restyle-2 branch 2 times, most recently from 286c221 to 18d984d Compare October 15, 2022 17:07
@BobDotCom BobDotCom marked this pull request as ready for review October 16, 2022 21:44
@BobDotCom BobDotCom enabled auto-merge (squash) October 16, 2022 21:44
Lulalaby
Lulalaby reviewed Oct 17, 2022
View reviewed changes
docs/conf.py Show resolved Hide resolved
Lulalaby
Lulalaby previously approved these changes Oct 17, 2022
View reviewed changes
@BobDotCom BobDotCom requested review from Dorukyum and a team October 18, 2022 17:10
@Lulalaby Lulalaby enabled auto-merge (squash) October 18, 2022 19:37
Middledot
Middledot approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@Middledot Middledot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lulalaby Lulalaby merged commit 5e445b3 into master Oct 18, 2022
@Lulalaby Lulalaby deleted the doc-restyle-2 branch October 18, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@Middledot Middledot Middledot approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees

@BobDotCom BobDotCom

Labels
documentation Improvements or additions to documentation priority: medium Medium Priority status: in progress Work in Progess
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BobDotCom @Lulalaby @ChickenDevs @Middledot