feat: Update AutoMod implementation #1809
Conversation
TheEnigmaBlade
changed the title
Add missing mention_spam value to AutoModTriggerType enum
for more information, see https://pre-commit.ci
…avor compatibility. Also expose the AutoModAction class to allow documentation to compile.
for more information, see https://pre-commit.ci
Lulalaby
force-pushed
the
fix/missing-automod-values
branch
from
2d7563c
to
3a15e9e
Compare
for more information, see https://pre-commit.ci
|
All requested changes have been applied. |
This change doesn't seem to have been made, and instead of removing it we could instead deprecate it and alias it for |
FWIW, your commit messages are fine. We use squash merges for PRs, only the PR title matters. |
…oModTriggerMetadata.mention_total_limit` to add supported trigger type.
The removal was reverted by @Lulalaby a little earlier, which is fine. Deprecation without aliasing would probably be best to avoid breaking changes, as aliasing I added the property to the docs for |
I actually think it should be removed, considering it's not on the api docs https://discord.com/developers/docs/resources/auto-moderation#auto-moderation-rule-object-trigger-types. |
|
It's still existing, some bots might encounter it, that's why I reverted the removal again |
|
According to the Discord staff I've talked to previously, the harmful link filter is permanently removed in favor of the spam filter. It only existed during the early beta tests and has not been public, so it would be impossible for a bot to ever receive such an event. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1809 +/- ##
==========================================
- Coverage 33.21% 33.18% -0.03%
==========================================
Files 96 96
Lines 18657 18674 +17
==========================================
+ Hits 6196 6197 +1
- Misses 12461 12477 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…a` and `AutoModActionMetadata`, and converted trigger metadata trigger type limits to a table.
for more information, see https://pre-commit.ci
…ModTriggerMetadata`
for more information, see https://pre-commit.ci
Summary
Since the original implementation of the AutoMod API (during the AutoMod beta), the API has been repeatedly changed. This pull request changes the following:
rule_trigger_type) toAutoModActionExecutionEvent, which seems to have been forgotten.regex_patterns,allow_list).mention_spamtrigger type enum value.harmful_linkenum value fromAutoModTriggerType, as Discord merged the filter withspamearly in the beta.I apologize about the improper commit messages, as I read the guidelines 3 months too late.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.