Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext.bridge): fix groups missing parent attr #1823

Merged
merged 6 commits into from Dec 14, 2022

Conversation

Middledot
Copy link
Member

Summary

self-explanatory
Fix #1816

Test code used
class Bot(bridge.Bot):
    def __init__(self):
        intents = discord.Intents.all()
        intents.presences = False
        super().__init__(
            intents=intents,
            command_prefix="::",
            case_insensitive=True,
            enable_debug_events=True,
            strip_after_prefix=True,
            description="something...",
            help_command=commands.DefaultHelpCommand()
        )

bot = Bot()
bot.load_extension("jishaku")

class Test(commands.Cog):
    @bridge.bridge_group(invoke_without_command=False)
    async def layer(self, ctx):
        await ctx.respond("hello!!!")

    @layer.command(invoke_without_command=False)
    async def one(self, ctx):
        await ctx.respond("All systems green")

bot.add_cog(Test())

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot Middledot added the bug Something isn't working label Dec 5, 2022
@Middledot Middledot requested a review from a team as a code owner December 5, 2022 23:37
Nzii3
Nzii3 previously approved these changes Dec 6, 2022
Lulalaby
Lulalaby previously approved these changes Dec 6, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) December 6, 2022 01:49
Copy link
Member

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

@Nzii3
Copy link
Contributor

Nzii3 commented Dec 6, 2022

Please add a changelog entry

Where?

@Lulalaby
Copy link
Member

Lulalaby commented Dec 7, 2022

Please add a changelog entry

Where?

In deez nuts :3

@Lulalaby
Copy link
Member

Lulalaby commented Dec 7, 2022

@Nzii3
Copy link
Contributor

Nzii3 commented Dec 7, 2022

just kidding https://github.com/Middledot/pycord/blob/bridge-fix/CHANGELOG.md

Crap I thought this was my pr :/

@Lulalaby
Copy link
Member

Lulalaby commented Dec 7, 2022

just kidding https://github.com/Middledot/pycord/blob/bridge-fix/CHANGELOG.md

Crap I thought this was my pr :/

LMFAO

@Middledot Middledot dismissed stale reviews from Lulalaby and Nzii3 via 550e7d3 December 12, 2022 23:53
@Middledot Middledot requested a review from a team as a code owner December 12, 2022 23:53
@Middledot
Copy link
Member Author

Apologies for the delay, the entry is added

@BobDotCom BobDotCom merged commit 647f00f into Pycord-Development:master Dec 14, 2022
@Middledot Middledot deleted the bridge-fix branch April 29, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute error for class.BridgeCommandGroup in HelpComand()
4 participants