Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add missing embedded activities #1859

Merged
merged 26 commits into from Jan 10, 2023
Merged

feat!: add missing embedded activities #1859

merged 26 commits into from Jan 10, 2023

Conversation

JustaSqu1d
Copy link
Member

@JustaSqu1d JustaSqu1d commented Jan 5, 2023

Summary

Adds missing activities. Source of information: https://gist.github.com/GeneralSadaf/42d91a2b6a93a7db7a39208f2d8b53ad

This PR also renames activities that have changed names.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@JustaSqu1d JustaSqu1d requested a review from a team as a code owner January 5, 2023 23:50
@JustaSqu1d JustaSqu1d changed the title feat: add missing activities feat!: add missing activities Jan 5, 2023
@JustaSqu1d JustaSqu1d marked this pull request as draft January 5, 2023 23:52
@JustaSqu1d JustaSqu1d marked this pull request as ready for review January 5, 2023 23:58
@JustaSqu1d JustaSqu1d changed the title feat!: add missing activities feat!: add missing embedded activities Jan 5, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
JustaSqu1d and others added 2 commits January 6, 2023 13:50
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Signed-off-by: JustaSqu1d <overenchanted.gaming@gmail.com>
@BobDotCom
Copy link
Member

Maybe a second changelog entry should be added under the "Removed" section to note that there were also values removed?

@JustaSqu1d
Copy link
Member Author

JustaSqu1d commented Jan 6, 2023

Maybe a second changelog entry should be added under the "Removed" section to note that there were also values removed?

What about also adding something under the "Changed" section to note the activities' names that were changed?

Should I remove the changelog entry in "Added" and "Removed" and put it under "Changed"?

@Lulalaby Lulalaby changed the title feat!: add missing embedded activities feat: add missing embedded activities Jan 7, 2023
@JustaSqu1d
Copy link
Member Author

@Lulalaby No, this is a breaking change. It changes the names of ocho to blazing_8s, chest_in_the_park to chess_in_the_park, etc.

@JustaSqu1d JustaSqu1d changed the title feat: add missing embedded activities feat!: add missing embedded activities Jan 7, 2023
@BobDotCom
Copy link
Member

Maybe a second changelog entry should be added under the "Removed" section to note that there were also values removed?

What about also adding something under the "Changed" section to note the activities' names that were changed?

Should I remove the changelog entry in "Added" and "Removed" and put it under "Changed"?

If there were only changes and additions, that would be best

Nzii3
Nzii3 previously approved these changes Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #1859 (b962416) into master (e165ebc) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
+ Coverage   33.21%   33.27%   +0.05%     
==========================================
  Files          96       96              
  Lines       18680    18695      +15     
==========================================
+ Hits         6205     6220      +15     
  Misses      12475    12475              
Flag Coverage Δ
macos-latest-3.10 33.25% <100.00%> (+0.05%) ⬆️
macos-latest-3.11 33.25% <100.00%> (+0.05%) ⬆️
macos-latest-3.8 33.26% <100.00%> (+0.05%) ⬆️
macos-latest-3.9 33.26% <100.00%> (+0.05%) ⬆️
ubuntu-latest-3.10 33.25% <100.00%> (+0.05%) ⬆️
ubuntu-latest-3.11 33.25% <100.00%> (+0.05%) ⬆️
ubuntu-latest-3.8 33.26% <100.00%> (+0.05%) ⬆️
ubuntu-latest-3.9 33.26% <100.00%> (+0.05%) ⬆️
windows-latest-3.10 33.25% <100.00%> (+0.05%) ⬆️
windows-latest-3.11 33.25% <100.00%> (+0.05%) ⬆️
windows-latest-3.8 33.26% <100.00%> (+0.05%) ⬆️
windows-latest-3.9 33.26% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/enums.py 79.61% <100.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e165ebc...b962416. Read the comment docs.

BobDotCom and others added 2 commits January 9, 2023 12:32
Adding "changed" and "removed" change-log categories entries
@JustaSqu1d JustaSqu1d added status: awaiting review Awaiting review from a maintainer priority: medium Medium Priority feature Implements a feature API Reflection Discords API wasn't correctly reflected in the lib labels Jan 9, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Signed-off-by: JustaSqu1d <overenchanted.gaming@gmail.com>
@BobDotCom BobDotCom enabled auto-merge (squash) January 10, 2023 15:57
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but as note: dev activities are restricted server side, so no use mostly

@BobDotCom BobDotCom merged commit ce16709 into Pycord-Development:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants