feat(ext.bridge): add walk command functions & dynamically fetch attrs in commands variants #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
changed the title
Signed-off-by: Middledot <78228142+Middledot@users.noreply.github.com>
for more information, see https://pre-commit.ci
As mentioned in https://docs.python.org/3.11/library/typing.html#typing.Generator, the Iterable and Iterator types can also be used in generator functions
BobDotCom
changed the title
for more information, see https://pre-commit.ci
Lulalaby
requested review from
Dorukyum and
plun1331
and removed request for
JustaSqu1d
Signed-off-by: Middledot <78228142+Middledot@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
After reviewing this, I don't remember why I said it depends on the other pr, so it can be reviewed and merged now |
Signed-off-by: plun1331 <49261529+plun1331@users.noreply.github.com>
8 tasks
BobDotCom
reviewed
Apr 26, 2023
BobDotCom
previously requested changes
Apr 26, 2023
Signed-off-by: Middledot <78228142+Middledot@users.noreply.github.com>
Lulalaby
previously approved these changes
Apr 29, 2023
|
wait for bob to review tho |
|
I updated the description explaining what I just did |
|
Nom Looks good |
|
@Lulalaby @BobDotCom Please review (then we can also get #1866 merged) |
Lulalaby
previously approved these changes
May 8, 2023
Signed-off-by: Lala Sabathil <lala@pycord.dev>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1867 +/- ##
==========================================
+ Coverage 33.23% 33.26% +0.02%
==========================================
Files 97 97
Lines 19038 19021 -17
==========================================
Hits 6328 6328
+ Misses 12710 12693 -17
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Lulalaby
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Further explanations in the changelog.
Should fix #1840
EDIT: The translation attributes are unique to slash commands so if you "dynamically" set them:
So I kept the code for setting and fetching the translations.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.