fix: images sending as 0 bytes in paginator if sent as io.BytesIO
#1881
Conversation
This fixes a bug where if a page is viewed more than once, the image wouldn't be displayed except the first time. Signed-off-by: Yaakov Schlachter <contact@cgprograms.com>
Signed-off-by: Yaakov Schlachter <contact@cgprograms.com>
for more information, see https://pre-commit.ci
|
Please stick to to the commit conventions |
Signed-off-by: Yaakov Schlachter <contact@cgprograms.com>
for more information, see https://pre-commit.ci
CompuGenius-Programs
changed the title
I apologize, fixed the PR title. Unfortunately, can't change the commit titles of the individual commits. |
That's fine, we squash per default, just the pr title is important |
Head branch was pushed to by a user without write access
Co-authored-by: Lala Sabathil <aiko@aitsys.dev> Signed-off-by: Yaakov Schlachter <contact@cgprograms.com>
CompuGenius-Programs
changed the title
io.BytesIO
|
Currently working with @BobDotCom to actually get the best fix possible across the whole framework, instead of a local fix to this function. My code will be deprecated then. |
|
does this works now @BobDotCom |
Apart from my suggested change, this has been tested and should be ready. |
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com> Signed-off-by: Yaakov Schlachter <contact@cgprograms.com>
for more information, see https://pre-commit.ci
Signed-off-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
for more information, see https://pre-commit.ci
Summary
This fixes a bug where if a page is viewed more than once, the image wouldn't be displayed except the first time.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.