Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GIF sticker format #1915

Merged
merged 6 commits into from Feb 10, 2023
Merged

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Feb 10, 2023

This pull requests fixes a bug which breaks pycord bots due to a new sticker format.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Dorukyum Dorukyum added priority: high High Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Feb 10, 2023
@Dorukyum Dorukyum added this to the v2.4 milestone Feb 10, 2023
@Dorukyum Dorukyum requested a review from a team as a code owner February 10, 2023 14:13
@Dorukyum Dorukyum self-assigned this Feb 10, 2023
@Dorukyum Dorukyum enabled auto-merge (squash) February 10, 2023 14:14
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1915 (44c310c) into master (af12f33) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 44c310c differs from pull request most recent head 8794c08. Consider uploading reports for the commit 8794c08 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1915   +/-   ##
=======================================
  Coverage   33.33%   33.34%           
=======================================
  Files          97       97           
  Lines       18753    18754    +1     
=======================================
+ Hits         6252     6253    +1     
  Misses      12501    12501           
Flag Coverage Δ
macos-latest-3.10 33.32% <50.00%> (+<0.01%) ⬆️
macos-latest-3.11 33.32% <50.00%> (+<0.01%) ⬆️
macos-latest-3.8 33.33% <50.00%> (+<0.01%) ⬆️
macos-latest-3.9 33.33% <50.00%> (+<0.01%) ⬆️
ubuntu-latest-3.10 33.32% <50.00%> (+<0.01%) ⬆️
ubuntu-latest-3.11 33.32% <50.00%> (+<0.01%) ⬆️
ubuntu-latest-3.8 33.33% <50.00%> (+<0.01%) ⬆️
ubuntu-latest-3.9 33.33% <50.00%> (+<0.01%) ⬆️
windows-latest-3.10 33.32% <50.00%> (+<0.01%) ⬆️
windows-latest-3.11 33.32% <50.00%> (+<0.01%) ⬆️
windows-latest-3.8 33.33% <50.00%> (+<0.01%) ⬆️
windows-latest-3.9 33.33% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/enums.py 79.96% <50.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af12f33...8794c08. Read the comment docs.

discord/enums.py Outdated Show resolved Hide resolved
Copy link
Member

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

• Changelog entry needed
• See my suggestion for avoidance of future KeyErrors if this happens again.

discord/enums.py Outdated Show resolved Hide resolved
Dorukyum and others added 2 commits February 10, 2023 19:59
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Lulalaby Lulalaby merged commit 08af163 into Pycord-Development:master Feb 10, 2023
@Dorukyum Dorukyum deleted the gif-stickers branch January 25, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants