Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly store advanced version_info data #1920

Merged
merged 3 commits into from Feb 10, 2023
Merged

Conversation

BobDotCom
Copy link
Member

@BobDotCom BobDotCom commented Feb 10, 2023

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom requested a review from a team as a code owner February 10, 2023 22:38
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1920 (804eccb) into master (4b84447) will increase coverage by 0.05%.
The diff coverage is 77.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1920      +/-   ##
==========================================
+ Coverage   33.33%   33.39%   +0.05%     
==========================================
  Files          97       97              
  Lines       18786    18811      +25     
==========================================
+ Hits         6263     6282      +19     
- Misses      12523    12529       +6     
Flag Coverage Δ
macos-latest-3.10 33.37% <77.14%> (+0.05%) ⬆️
macos-latest-3.11 33.37% <77.14%> (+0.05%) ⬆️
macos-latest-3.8 ?
macos-latest-3.9 33.39% <77.14%> (+0.05%) ⬆️
ubuntu-latest-3.10 33.37% <77.14%> (+0.05%) ⬆️
ubuntu-latest-3.11 33.37% <77.14%> (+0.05%) ⬆️
ubuntu-latest-3.8 33.39% <77.14%> (+0.05%) ⬆️
ubuntu-latest-3.9 33.39% <77.14%> (+0.05%) ⬆️
windows-latest-3.10 ?
windows-latest-3.11 ?
windows-latest-3.8 33.39% <77.14%> (+0.05%) ⬆️
windows-latest-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/_version.py 81.08% <77.14%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b84447...804eccb. Read the comment docs.

@BobDotCom
Copy link
Member Author

changelog entry will be added separately

@BobDotCom BobDotCom merged commit f12e4e5 into master Feb 10, 2023
@BobDotCom BobDotCom deleted the fix-versioninfo branch February 10, 2023 22:44
@BobDotCom BobDotCom linked an issue Apr 26, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change how version info is stored
2 participants