Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: suppress FFMPEG output #1993

Merged
merged 8 commits into from Apr 18, 2023
Merged

feat: suppress FFMPEG output #1993

merged 8 commits into from Apr 18, 2023

Conversation

OmLanke
Copy link
Contributor

@OmLanke OmLanke commented Mar 29, 2023 •
edited

Summary

Suppress FFMPEG output when audio is finished recording

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@OmLanke OmLanke requested a review from a team as a code owner March 29, 2023 14:39
@JustaSqu1d JustaSqu1d added feature Implements a feature python changelog needed status: awaiting review Awaiting review from a maintainer labels Mar 29, 2023
plun1331
plun1331 previously requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog

@OmLanke
Copy link
Contributor Author

OmLanke commented Mar 30, 2023

Please add a changelog

What type would this be? Added, Removed, Updated, or Changed?

@Lulalaby
Copy link
Member

you updated the call args, so update

@OmLanke
Copy link
Contributor Author

OmLanke commented Mar 30, 2023

you updated the call args, so update

Uh. Just found it is Added, Removed, Fixed and Changed from previous changelogs.

Have put in Changed for the time being

@OmLanke
Merge branch 'master' into supress-ffmpeg
f0d6a98 
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
@OmLanke OmLanke requested a review from plun1331 March 31, 2023 14:45
plun1331
plun1331 reviewed Mar 31, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@OmLanke @plun1331
Update CHANGELOG.md
c34ef23 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
@Lulalaby Lulalaby requested a review from plun1331 April 2, 2023 10:52
@OmLanke
Copy link
Contributor Author

OmLanke commented Apr 13, 2023

@pycord-development/core-developers pending review

@Lulalaby Lulalaby enabled auto-merge (squash) April 17, 2023 18:00
@Lulalaby Lulalaby requested a review from BobDotCom April 17, 2023 18:01
@Lulalaby Lulalaby disabled auto-merge April 18, 2023 01:39
@Lulalaby Lulalaby merged commit 8fb956c into Pycord-Development:master Apr 18, 2023
28 checks passed
@OmLanke OmLanke deleted the supress-ffmpeg branch April 24, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

Assignees
No one assigned
Labels
feature Implements a feature status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OmLanke @Lulalaby @plun1331 @JustaSqu1d