Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduled_events): location editing breaking #1998

Merged

Conversation

Middledot
Copy link
Member

Summary

Fix #1847
Changing an event's location from string (external) to a channel breaks.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Middledot Middledot requested a review from a team as a code owner April 2, 2023 21:31
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #1998 (dcabff4) into master (614f794) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
- Coverage   33.33%   33.33%   -0.01%     
==========================================
  Files          97       97              
  Lines       18897    18898       +1     
==========================================
  Hits         6300     6300              
- Misses      12597    12598       +1     
Flag Coverage Δ
macos-latest-3.10 33.32% <0.00%> (-0.01%) ⬇️
macos-latest-3.11 33.32% <0.00%> (-0.01%) ⬇️
macos-latest-3.8 33.33% <0.00%> (-0.01%) ⬇️
macos-latest-3.9 33.33% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.32% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.32% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.33% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.33% <0.00%> (-0.01%) ⬇️
windows-latest-3.10 33.32% <0.00%> (-0.01%) ⬇️
windows-latest-3.11 33.32% <0.00%> (-0.01%) ⬇️
windows-latest-3.8 33.33% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 33.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/scheduled_events.py 31.45% <0.00%> (-0.26%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 614f794...dcabff4. Read the comment docs.

@JustaSqu1d JustaSqu1d added bug Something isn't working status: awaiting review Awaiting review from a maintainer API Reflection Discords API wasn't correctly reflected in the lib labels Apr 2, 2023
@plun1331 plun1331 merged commit 4a5099a into Pycord-Development:master Apr 3, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib bug Something isn't working status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scheduled_event.edit does not work if location changed from external to voice
5 participants