Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): revert removal of custom search scoring #2019

Merged
merged 4 commits into from Apr 17, 2023
Merged

chore(docs): revert removal of custom search scoring #2019

merged 4 commits into from Apr 17, 2023

Conversation

BobDotCom
Copy link
Member

Summary

This pull request reverts the removal of a custom documentation search scoring script. This script was removed when the docs were refactored, and it seems to have caused issues with search priorities.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@BobDotCom BobDotCom requested a review from a team as a code owner April 17, 2023 15:24
plun1331
plun1331 previously requested changes Apr 17, 2023
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect path

docs/conf.py Outdated Show resolved Hide resolved
@Lulalaby @plun1331
Update docs/conf.py
eb5c530 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
@Lulalaby Lulalaby requested a review from plun1331 April 17, 2023 15:35
@Lulalaby Lulalaby enabled auto-merge (squash) April 17, 2023 15:40
@Lulalaby Lulalaby requested review from ChickenDevs and removed request for plun1331 April 17, 2023 15:41
@Lulalaby Lulalaby added documentation Improvements or additions to documentation priority: high High Priority labels Apr 17, 2023
@Lulalaby
Copy link
Member

Before:
before

After:
after

@BobDotCom
Copy link
Member Author

Here's a comparison when searching for "Sticker"

Prior to Refactor Current This PR
Screenshot 2023-04-17 at 10 42 53 AM image Screenshot 2023-04-17 at 10 43 57 AM

@BobDotCom BobDotCom requested a review from plun1331 April 17, 2023 15:46
@Lulalaby
Copy link
Member

these damn docs take always way too long 🤣

@Lulalaby Lulalaby merged commit f5e780a into master Apr 17, 2023
47 checks passed
@BobDotCom BobDotCom deleted the searchscore branch April 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation priority: high High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BobDotCom @Lulalaby @plun1331 @ChickenDevs