Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a key feature to README #202

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

Grace-codes
Copy link
Contributor

Summary

This PR adds a key feature to README

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@splxne
Copy link

splxne commented Sep 16, 2021

buttons + dropdown too?

@Grace-codes
Copy link
Contributor Author

I'll add that too

@izxxr
Copy link
Contributor

izxxr commented Sep 16, 2021

Are these really needed? 🤔

I mean, A key feature like "Provides entire API coverage" or "Implements the entire Discord API" would be better.

@Grace-codes
Copy link
Contributor Author

It is. People keep on asking if pycord has slash commands or buttons. And there's people like this
image

@izxxr
Copy link
Contributor

izxxr commented Sep 16, 2021

It is. People keep on asking if pycord has slash commands or buttons. And there's people like this
image

Scrolling down by few inches reveals slash commands examples. 😄

@@ -19,6 +19,7 @@ Key Features
- Modern Pythonic API using ``async`` and ``await``.
- Proper rate limit handling.
- Optimised in both speed and memory.
- Supports Slash Commands, Context Menus and Message Components.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have something like "Supports Slash Commands, Context Menus and Message Components via gateway". I am not sure though if we do slash commands through http or the gateway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All events are received through the gateway, altough commands are registered through http requests.

@BobDotCom BobDotCom merged commit cd70e29 into Pycord-Development:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants