New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Restore overriding on_application_command_error via listener #2044
Conversation
Yes please update the changelog with info that this is a fix |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2044 +/- ##
==========================================
- Coverage 33.24% 33.23% -0.01%
==========================================
Files 97 97
Lines 19036 19038 +2
==========================================
Hits 6328 6328
- Misses 12708 12710 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Geez fuck off pre commit bot |
Mhh seems like readthedocs is completely broken. I'm gonna look into that after I've slept. |
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Summary
Reverts an out of scope change made in #1907 so the default
on_application_command_error
won't fire if listeners for it exist.Side note: should changelog be updated for this?
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.