refactor!: embed classes

[OmLanke]

Summary

Breaking Change -

Attributes for Author, Footer, Image, Thumbnail, Video, and Provider on the embed will now return None instead of EmbedProxy, when they are not set. This change is done for correct API reflection.

This allowed the complete removal of EmbedProxy in favour of separate classes for the above attributes. This allows for concrete typing support. The new classes are EmbedAuthor, EmbedFooter, EmbedMedia and EmbedProvider

Breaking Change -

Embed.Empty and EmptyEmbed have now been removed in favour of None

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.

[Lulalaby]

we shouldn't set required fields to none.
i.e. author.name

[codecov]

Codecov Report

Merging #2063 (952bf1a) into master (5175fae) will decrease coverage by 0.02%.
The diff coverage is 27.81%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2063      +/-   ##
==========================================
- Coverage   33.24%   33.22%   -0.02%     
==========================================
  Files          97       97              
  Lines       19039    19092      +53     
==========================================
+ Hits         6329     6343      +14     
- Misses      12710    12749      +39     

Flag	Coverage Δ
macos-latest-3.10	33.20% <27.81%> (-0.02%)	⬇️
macos-latest-3.11	33.20% <27.81%> (-0.02%)	⬇️
macos-latest-3.8	33.21% <27.81%> (-0.02%)	⬇️
macos-latest-3.9	33.21% <27.81%> (-0.02%)	⬇️
ubuntu-latest-3.10	33.20% <27.81%> (-0.02%)	⬇️
ubuntu-latest-3.11	33.20% <27.81%> (-0.02%)	⬇️
ubuntu-latest-3.8	33.21% <27.81%> (-0.02%)	⬇️
ubuntu-latest-3.9	33.21% <27.81%> (-0.02%)	⬇️
windows-latest-3.10	33.20% <27.81%> (-0.02%)	⬇️
windows-latest-3.11	33.20% <27.81%> (-0.02%)	⬇️
windows-latest-3.8	33.21% <27.81%> (-0.02%)	⬇️
windows-latest-3.9	33.21% <27.81%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
discord/embeds.py	25.21% <27.81%> (+0.21%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5175fae...952bf1a. Read the comment docs.

[Lulalaby]

nice work om

h

[NeloBlivion]

All in all a good effort, mainly needs some fine tuning.
Please update all necessary docs;

• attrs like author, footer and video should refer to their new class.
• Remove Empty and EmbedProxy references.
• Add all new classes such as EmbedMedia to data_classes.rst.

Any changes you make to docs can be previewed here.

[pullapprove4]

This pull request is in the In review step of the Default workflow.

Since there are no pending review teams, @Om1609 shoulde determine what is required to move this PR forward.

[Revnoplex]

Not sure if this has been noted as part of the breaking changes but I noticed another breaking change which was the fields argument of Embed is no longer accepting None
which would cause 'NoneType' object is not iterable here:

File "bot-dir/venv/lib/python3.11/site-packages/discord/embeds.py", line 995, in to_dict
    result["fields"] = [field.to_dict() for field in self._fields]
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[OmLanke]

Yes that seems like a missed bug. I'll fix this in a bit

[OmLanke]

Yes that seems like a missed bug. I'll fix this in a bit

Already fixed by #2071