fix: creating forum threads with files #2075
Merged
+43
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotcubit
force-pushed
the
forum-thread-files
branch
from
1b03a56
to
2c828c4
Compare
elliotcubit
changed the title
Lulalaby
previously requested changes
May 14, 2023
elliotcubit
force-pushed
the
forum-thread-files
branch
from
2c828c4
to
4fa1343
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2075 +/- ##
==========================================
- Coverage 33.14% 33.13% -0.02%
==========================================
Files 97 97
Lines 19129 19136 +7
==========================================
Hits 6340 6340
- Misses 12789 12796 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Lulalaby
requested review from
Dorukyum and
JustaSqu1d
and removed request for
VincentRPS
JustaSqu1d
suggested changes
May 14, 2023
elliotcubit
force-pushed
the
forum-thread-files
branch
from
4fa1343
to
41d7b6d
Compare
Dorukyum
changed the title
Lulalaby
previously approved these changes
May 17, 2023
plun1331
reviewed
May 18, 2023
auto-merge was automatically disabled
May 20, 2023 20:57
Head branch was pushed to by a user without write access
elliotcubit
force-pushed
the
forum-thread-files
branch
from
41d7b6d
to
b50d3ef
Compare
elliotcubit
force-pushed
the
forum-thread-files
branch
from
b50d3ef
to
18717cb
Compare
JustaSqu1d
previously approved these changes
May 20, 2023
plun1331
reviewed
May 25, 2023
plun1331
added
priority: high
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com> Signed-off-by: Elliot Cubit <7256340+elliotcubit@users.noreply.github.com>
plun1331
approved these changes
May 25, 2023
Lulalaby
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows creating a new forum thread with files. As mentioned in the issue, the thread creation endpoint supports uploading files directly, so there is no need to use a separate endpoint when this argument is provided to
create_thread.Fixes #1949
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.