fix: miscellaneous pomelo updates #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustaSqu1d
added
documentation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## pomelo #2076 +/- ##
==========================================
+ Coverage 33.04% 33.16% +0.12%
==========================================
Files 97 97
Lines 19303 19115 -188
==========================================
- Hits 6378 6340 -38
+ Misses 12925 12775 -150
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Dorukyum
requested changes
May 17, 2023
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Lulalaby
reviewed
May 17, 2023
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
|
Please add a changelog entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
User.display_nameand simplifyMember.display_nameglobal_nameasNoneif it's an empty string__str__to avoid matching username andglobal_nameglobal_nameset before migrationChanges to be included in the main PR's changelog.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.