Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make AuditLogEntry user/user_id optional #2079

Merged
merged 2 commits into from May 19, 2023

Conversation

NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented May 19, 2023

Summary

So apparently it's possible to recieve a user_id of None for audit log entries...
image
image
Thus it's been made optional.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested a review from a team as a code owner May 19, 2023 22:07
@pullapprove4 pullapprove4 bot requested review from Lulalaby and Middledot May 19, 2023 22:07
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #2079 (3014740) into master (7988904) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2079      +/-   ##
==========================================
- Coverage   33.16%   33.16%   -0.01%     
==========================================
  Files          97       97              
  Lines       19115    19117       +2     
==========================================
  Hits         6340     6340              
- Misses      12775    12777       +2     
Flag Coverage Δ
macos-latest-3.10 33.14% <0.00%> (-0.01%) ⬇️
macos-latest-3.11 33.14% <0.00%> (-0.01%) ⬇️
macos-latest-3.8 33.16% <0.00%> (-0.01%) ⬇️
macos-latest-3.9 33.16% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.14% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.14% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.16% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.16% <0.00%> (-0.01%) ⬇️
windows-latest-3.10 33.14% <0.00%> (-0.01%) ⬇️
windows-latest-3.11 33.14% <0.00%> (-0.01%) ⬇️
windows-latest-3.8 33.16% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 33.16% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/audit_logs.py 27.53% <ø> (ø)
discord/raw_models.py 27.58% <0.00%> (-0.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7988904...3014740. Read the comment docs.

@Lulalaby Lulalaby merged commit 4364260 into Pycord-Development:master May 19, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants