Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add icon and unicode_emoji to Guild.create_role #2086

Merged
merged 3 commits into from May 23, 2023
Merged

feat: Add icon and unicode_emoji to Guild.create_role #2086

merged 3 commits into from May 23, 2023

Conversation

NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented May 23, 2023 •
edited

Summary

The icon and unicode_emoji args have been available in Role.edit from the start, but were never added to Guild.create_role.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested a review from a team as a code owner May 23, 2023 03:54
@JustaSqu1d JustaSqu1d added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature python API Reflection Discords API wasn't correctly reflected in the lib labels May 23, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) May 23, 2023 03:56
@Lulalaby Lulalaby merged commit 7bbb42a into Pycord-Development:master May 23, 2023
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@JustaSqu1d JustaSqu1d JustaSqu1d approved these changes

@CodeWithSwastik CodeWithSwastik Awaiting requested review from CodeWithSwastik

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

Assignees
No one assigned
Labels
API Reflection Discords API wasn't correctly reflected in the lib feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeloBlivion @Lulalaby @JustaSqu1d