Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust default_avatar behavior depending on username #2087

Merged
merged 4 commits into from May 23, 2023

Conversation

NeloBlivion
Copy link
Member

Summary

As per discord/discord-api-docs#6130 (comment), default_avatar should still use discrim if the user hasn't migrated yet.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested a review from a team as a code owner May 23, 2023 04:03
@Lulalaby Lulalaby enabled auto-merge (squash) May 23, 2023 04:06
@JustaSqu1d JustaSqu1d added API Reflection Discords API wasn't correctly reflected in the lib status: awaiting review Awaiting review from a maintainer upcoming discord feature Involves a feature not yet fully released by Discord labels May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #2087 (99d3134) into master (7bbb42a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2087      +/-   ##
==========================================
- Coverage   33.15%   33.14%   -0.01%     
==========================================
  Files          97       97              
  Lines       19125    19126       +1     
==========================================
  Hits         6340     6340              
- Misses      12785    12786       +1     
Flag Coverage Δ
macos-latest-3.10 33.13% <0.00%> (-0.01%) ⬇️
macos-latest-3.11 33.13% <0.00%> (-0.01%) ⬇️
macos-latest-3.8 33.14% <0.00%> (-0.01%) ⬇️
macos-latest-3.9 33.14% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.13% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.13% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.14% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.14% <0.00%> (-0.01%) ⬇️
windows-latest-3.10 33.13% <0.00%> (-0.01%) ⬇️
windows-latest-3.11 33.13% <0.00%> (-0.01%) ⬇️
windows-latest-3.8 33.14% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 33.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/user.py 37.50% <0.00%> (-0.19%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bbb42a...99d3134. Read the comment docs.

@Lulalaby Lulalaby merged commit ad7056d into Pycord-Development:master May 23, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib status: awaiting review Awaiting review from a maintainer upcoming discord feature Involves a feature not yet fully released by Discord
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants