fix: values access before interaction #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plun1331
added
bug
pullapprove4
bot
requested review from
CodeWithSwastik,
VincentRPS,
Lulalaby,
WhoIsConch,
Middledot,
BobDotCom and
Dorukyum
|
what is pullapprove smoking |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2104 +/- ##
==========================================
- Coverage 33.13% 33.13% -0.01%
==========================================
Files 97 97
Lines 19139 19141 +2
==========================================
Hits 6342 6342
- Misses 12797 12799 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Signed-off-by: plun1331 <49261529+plun1331@users.noreply.github.com>
Lulalaby
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug that caused an AttributeError to be raised from
Select.valuesif the select had not been interacted with yet, specifically non-string selects.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.