Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for guild scheduled events #211

Merged
merged 80 commits into from
Jan 1, 2022
Merged

Add support for guild scheduled events #211

merged 80 commits into from
Jan 1, 2022

Conversation

Middledot
Copy link
Member

@Middledot Middledot commented Sep 17, 2021 •
edited

Summary

This pull request is supposed to implement guild scheduled events from issue #210 (discord-api-docs#3586)

Checklist

  • HTTP methods
  • MANAGE_EVENTS permission (already added)
  • Gateway
    • state.parse_x for events
    • Scheduled Events Intent
  • Scheduled Event Objects/Attrs
    • Cache implementation
    • ScheduledEvent
      • event.edit()
      • event.delete()
      • event.users() (should be similar to channel.history())
    • guild.create_scheduled_event()
    • guild.fetch_scheduled_events()
    • guild.fetch_event()
  • Enums
    • Audit log enums (already added)
    • Scheduled event status enums
  • Audit log
    • Converter for scheduled events
    • Transform things
    • Converting Location to a Location Object
  • Invite related things
    • event_id added to http method
    • event_id added to invite fetch method
    • event fields in create invite
  • Documentation
    • guild.x and event.x methods
    • Events (gateway)
    • enums
  • Finalize Typehints
    • Invites, etc.
    • Request response typehints
    • scheduled_events.py typehints

Notes

  • The guild events implementation is going to implemented the same way as members and invites (a mix ig)
  • This implementation should be tested before merging as I have no idea if this actually works

Resources

discord/discord-api-docs#4107
discord/discord-api-docs#4113
discord/discord-api-docs#4139
discord/discord-api-docs#4150
discord/discord-api-docs#4152
discord/discord-api-docs@37a25dd

https://discord.com/developers/docs/resources/guild-scheduled-event
https://discord.com/developers/docs/topics/gateway#guild-scheduled-event-create
https://discord.com/developers/docs/resources/invite#get-invite

@Middledot Middledot changed the title Add http methods for guild events Add support for guild scheduled events Sep 17, 2021
@CodeWithSwastik
Copy link
Contributor

CodeWithSwastik commented Sep 18, 2021 •
edited

I think MANAGE EVENTS is already a permission.

@Middledot
Copy link
Member Author

Middledot commented Sep 18, 2021 •
edited

Yeah I ticked it and mentioned that

@CodeWithSwastik CodeWithSwastik added the status: in progress Work in Progess label Sep 18, 2021
@Dorukyum Dorukyum added this to In progress in v2.0 Sep 19, 2021
@Middledot @izxxr
Remove british language
1deb0ac 
I think that’s what it is

Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
@Middledot Middledot mentioned this pull request Oct 16, 2021
Merged
3 tasks
@Lulalaby Lulalaby added the feature Implements a feature label Oct 30, 2021
@Lulalaby Lulalaby linked an issue Oct 30, 2021 that may be closed by this pull request
Add support for guild events #210
Closed
@Lulalaby Lulalaby added the priority: low Low Priority label Nov 9, 2021
@Middledot Middledot added status: awaiting review Awaiting review from a maintainer and removed status: in progress Work in Progess labels Dec 26, 2021
@Middledot Middledot marked this pull request as ready for review December 26, 2021 23:16
Lulalaby
Lulalaby previously approved these changes Dec 27, 2021
View reviewed changes
@Middledot
Copy link
Member Author

I think there should be more than 2 reviews before merging

Dorukyum
Dorukyum approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Lulalaby
Lulalaby approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment •
edited by Dorukyum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BobDotCom please do an additional review

@Lulalaby
Copy link
Member

And for gods sake, please squash

ChickenDevs
ChickenDevs approved these changes Jan 1, 2022
View reviewed changes
Copy link
Member

@ChickenDevs ChickenDevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me, still waiting on @BobDotCom

@Lulalaby Lulalaby merged commit 7ca9d17 into Pycord-Development:master Jan 1, 2022
v2.0 automation moved this from In progress to Done Jan 1, 2022
@honzajavorek
Copy link
Contributor

I just wanted to say that I installed pycord with support for scheduled events as soon as you merged this PR and it works and I love you all.

@Middledot
Copy link
Member Author

Glad to hear it works for you!

VincentRPS pushed a commit to VincentRPS/pycord that referenced this pull request Jan 22, 2022
@Middledot @izxxr @VincentRPS
Add support for guild scheduled events (Pycord-Development#211)
05531a6 
Co-authored-by: Izhar Ahmad <54180221+nerdguyahmad@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentRPS VincentRPS VincentRPS left review comments

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@izxxr izxxr Awaiting requested review from izxxr

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

Assignees

@Middledot Middledot

Labels
feature Implements a feature priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
No open projects
v2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add support for guild events
9 participants
@Middledot @CodeWithSwastik @Lulalaby @VincentRPS @honzajavorek @Dorukyum @izxxr @ChickenDevs @BobDotCom