Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add suppress and allowed_mentions parameters #2138

Merged
merged 7 commits into from Jun 24, 2023

Conversation

OmLanke
Copy link
Contributor

@OmLanke OmLanke commented Jun 23, 2023

Summary

Adds suppress and allowed_mentions parameters to InteractionResponse.edit_message.
Also adds suppress parameter for editing messages using webhooks.

The suppress_embeds flag and allowed_mentions are supported for InteractionResponse.edit_message https://discord.com/developers/docs/interactions/receiving-and-responding#interaction-response-object-messages

The suppress_embeds flags is undocumented for editing message by webhooks, but it works.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • [] If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Lulalaby
Lulalaby previously approved these changes Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2138 (e67e361) into master (b101302) will decrease coverage by 0.02%.
The diff coverage is 10.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2138      +/-   ##
==========================================
- Coverage   33.88%   33.86%   -0.02%     
==========================================
  Files         109      109              
  Lines       22343    22360      +17     
==========================================
+ Hits         7571     7573       +2     
- Misses      14772    14787      +15     
Flag Coverage Δ
macos-latest-3.10 33.84% <10.52%> (-0.02%) ⬇️
macos-latest-3.11 33.84% <10.52%> (-0.02%) ⬇️
macos-latest-3.8 33.85% <10.52%> (-0.02%) ⬇️
macos-latest-3.9 33.85% <10.52%> (-0.02%) ⬇️
ubuntu-latest-3.10 33.84% <10.52%> (-0.02%) ⬇️
ubuntu-latest-3.11 33.84% <10.52%> (-0.02%) ⬇️
ubuntu-latest-3.8 33.85% <10.52%> (-0.02%) ⬇️
ubuntu-latest-3.9 33.85% <10.52%> (-0.02%) ⬇️
windows-latest-3.10 33.84% <10.52%> (-0.02%) ⬇️
windows-latest-3.11 33.84% <10.52%> (-0.02%) ⬇️
windows-latest-3.8 33.85% <10.52%> (-0.02%) ⬇️
windows-latest-3.9 33.85% <10.52%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/webhook/sync.py 22.18% <0.00%> (-0.15%) ⬇️
discord/interactions.py 19.21% <8.33%> (-0.34%) ⬇️
discord/webhook/async_.py 23.22% <20.00%> (+0.05%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b101302...e67e361. Read the comment docs.

auto-merge was automatically disabled June 23, 2023 21:34

Head branch was pushed to by a user without write access

Lulalaby
Lulalaby previously approved these changes Jun 23, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) June 23, 2023 22:06
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Lulalaby Lulalaby merged commit b076bd3 into Pycord-Development:master Jun 24, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants