Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: basic_autocomplete values can be Iterable[OptionChoice] #2164

Merged
merged 1 commit into from Jul 9, 2023
Merged

fix: basic_autocomplete values can be Iterable[OptionChoice] #2164

merged 1 commit into from Jul 9, 2023

Conversation

CarrotManMatt
Copy link
Contributor

@CarrotManMatt CarrotManMatt commented Jul 6, 2023 •
edited

Summary

Fixes #2163

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@CarrotManMatt
Adds OptionChoice to typehint of basic_autocomplete values argument
2e21219 
Signed-off-by: CarrotManMatt <108596565+CarrotManMatt@users.noreply.github.com>
@CarrotManMatt CarrotManMatt requested a review from a team as a code owner July 6, 2023 19:00
@pullapprove4 pullapprove4 bot requested a review from Middledot July 6, 2023 19:00
@pullapprove4 pullapprove4 bot requested a review from VincentRPS July 6, 2023 19:00
@CarrotManMatt CarrotManMatt changed the title Adds OptionChoice to typehint of basic_autocomplete values argument 🚨 Adds OptionChoice to typehint of basic_autocomplete values argument Jul 6, 2023
@CarrotManMatt CarrotManMatt changed the title 🚨 Adds OptionChoice to typehint of basic_autocomplete values argument 🚨 style: Adds OptionChoice to typehint of basic_autocomplete values argument Jul 6, 2023
@CarrotManMatt CarrotManMatt changed the title 🚨 style: Adds OptionChoice to typehint of basic_autocomplete values argument style:rotating_light: style:: OptionChoice to typehint of basic_autocomplete values argument Jul 6, 2023
@CarrotManMatt CarrotManMatt changed the title style:rotating_light: style:: OptionChoice to typehint of basic_autocomplete values argument style:rotating_light:: OptionChoice to typehint of basic_autocomplete values argument Jul 6, 2023
@CarrotManMatt CarrotManMatt changed the title style:rotating_light:: OptionChoice to typehint of basic_autocomplete values argument style: 🚨 OptionChoice to typehint of basic_autocomplete values argument Jul 6, 2023
@JustaSqu1d JustaSqu1d self-requested a review July 6, 2023 19:09
@Dorukyum Dorukyum changed the title style: 🚨 OptionChoice to typehint of basic_autocomplete values argument fix: basic_autocomplete values can be Iterable[OptionChoice] Jul 6, 2023
@Dorukyum
Copy link
Member

Dorukyum commented Jul 9, 2023

[ ] If code changes were made then they have been tested.

Please make sure to test this.

@CarrotManMatt
Copy link
Contributor Author

[ ] If code changes were made then they have been tested.

Please make sure to test this.

There weren't any code changes made that would require testing per-se, however I have validated that the changes I made to the type-hinting are correctly reflected by static type-checkers like mypy & Pycharm's in-built type checker.

@Dorukyum
Copy link
Member

Dorukyum commented Jul 9, 2023

[ ] If code changes were made then they have been tested.

Please make sure to test this.

There weren't any code changes made that would require testing per-se, however I have validated that the changes I made to the type-hinting are correctly reflected by static type-checkers like mypy & Pycharm's in-built type checker.

That's fine, I want every pull request to be tested because sometimes there can be unforeseen exceptions such as circular imports.

@Dorukyum Dorukyum enabled auto-merge (squash) July 9, 2023 14:19
@Dorukyum Dorukyum merged commit fc3825b into Pycord-Development:master Jul 9, 2023
35 of 39 checks passed
@CarrotManMatt CarrotManMatt deleted the patch-1 branch July 10, 2023 01:03
@pullapprove4
Copy link

pullapprove4 bot commented Jul 27, 2023

Please add a changelog entry

@pullapprove4
Copy link

pullapprove4 bot commented Aug 31, 2023

Changelog requirements met

Lulalaby pushed a commit that referenced this pull request Aug 31, 2023
@CarrotManMatt @pre-commit-ci
docs: Update CHANGELOG.md with merged pull request #2164 (#2220)
2256710 
* Update CHANGELOG.md

Signed-off-by: CarrotManMatt <108596565+CarrotManMatt@users.noreply.github.com>

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Signed-off-by: CarrotManMatt <108596565+CarrotManMatt@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@JustaSqu1d JustaSqu1d JustaSqu1d approved these changes

@Middledot Middledot Awaiting requested review from Middledot

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing OptionChoice as one of the possible values in basic_autocomplete's typehint
3 participants
@CarrotManMatt @Dorukyum @JustaSqu1d