Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace orjson support with msgspec #2170

Merged
merged 4 commits into from Jul 14, 2023
Merged

refactor: replace orjson support with msgspec #2170

merged 4 commits into from Jul 14, 2023

Conversation

VincentRPS
Copy link
Member

Summary

Replaces orjson with the faster msgspec library.

Should not lead to any breaking changes as it does not change any method.

Msgspec averages to be much faster then orjson in most cases:

download (1)

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@pullapprove4 pullapprove4 bot requested a review from ChickenDevs July 14, 2023 02:30
@JustaSqu1d JustaSqu1d added the dependencies Pull requests that update a dependency file label Jul 14, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) July 14, 2023 04:53
@Lulalaby Lulalaby merged commit 9926ef5 into master Jul 14, 2023
44 checks passed
@Lulalaby Lulalaby deleted the msgspec branch July 27, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants