Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: thread creation payload #2191

Merged
merged 3 commits into from Aug 2, 2023
Merged

fix: thread creation payload #2191

merged 3 commits into from Aug 2, 2023

Conversation

VincentRPS
Copy link
Member

@VincentRPS VincentRPS commented Aug 2, 2023 •
edited by Lulalaby

Summary

has_message is now deprecated and has been replaced with the simple message key. This applies that change.

Fixes #2190
Closes #1735

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@VincentRPS
fix: thread creation payload
49f1090 
`has_message` is now deprecated and has been replaced with the simple `message` key.
@VincentRPS
chore: update changelog
2ba0cb2
@VincentRPS VincentRPS added priority: high High Priority status: awaiting review Awaiting review from a maintainer API Reflection Discords API wasn't correctly reflected in the lib labels Aug 2, 2023
@VincentRPS VincentRPS added this to the v2.5 milestone Aug 2, 2023
@VincentRPS VincentRPS requested a review from a team as a code owner August 2, 2023 14:10
@VincentRPS VincentRPS self-assigned this Aug 2, 2023
@VincentRPS VincentRPS linked an issue Aug 2, 2023 that may be closed by this pull request
Forum channels still use payloads from early beta #2190
Closed
@Lulalaby Lulalaby enabled auto-merge (squash) August 2, 2023 14:15
@Lulalaby Lulalaby merged commit 1a03d97 into master Aug 2, 2023
47 checks passed
@Lulalaby Lulalaby deleted the fix/2190 branch August 2, 2023 14:17
@Pycord-Development Pycord-Development deleted a comment from pullapprove4 bot Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@VincentRPS VincentRPS

Labels
API Reflection Discords API wasn't correctly reflected in the lib priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.5
2 participants
@VincentRPS @Lulalaby