Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing setters for Embed properties #2198

Merged
merged 2 commits into from Aug 6, 2023

Conversation

OmLanke
Copy link
Contributor

@OmLanke OmLanke commented Aug 6, 2023

Summary

Adds property setters for embed.author, embed.footer, embed.image, and embed.thumbnail.

Fixes #2197

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@OmLanke
Copy link
Contributor Author

OmLanke commented Aug 6, 2023

Just realised I used the wrong base branch

@Lulalaby Lulalaby added the bug Something isn't working label Aug 6, 2023
@Lulalaby Lulalaby added this to the v2.5 milestone Aug 6, 2023
@Lulalaby Lulalaby merged commit f5d0f22 into Pycord-Development:master Aug 6, 2023
26 checks passed
Lulalaby added a commit that referenced this pull request Aug 7, 2023
Lulalaby added a commit that referenced this pull request Aug 7, 2023
Lulalaby added a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Embed class missing property setters
2 participants