Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: offset-aware time when preparing tasks #2271

Merged
merged 3 commits into from Nov 30, 2023
Merged

fix: offset-aware time when preparing tasks #2271

merged 3 commits into from Nov 30, 2023

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Nov 30, 2023 •
edited

Summary

Fixes #1990.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Dorukyum Dorukyum added bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Nov 30, 2023
@Dorukyum Dorukyum added this to the v2.5 milestone Nov 30, 2023
@Dorukyum Dorukyum self-assigned this Nov 30, 2023
@Dorukyum Dorukyum requested a review from a team as a code owner November 30, 2023 16:01
Lulalaby
Lulalaby previously approved these changes Nov 30, 2023
View reviewed changes
@Dorukyum Dorukyum enabled auto-merge (squash) November 30, 2023 16:05
Lulalaby
Lulalaby approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fucking review

@Dorukyum Dorukyum merged commit 9b4f15a into Pycord-Development:master Nov 30, 2023
26 checks passed
@Dorukyum Dorukyum deleted the offset-aware-time branch December 1, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@Dorukyum Dorukyum

Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.

py-cord loop throws an task exception when set to a fixed dst and offset-aware time
2 participants
@Dorukyum @Lulalaby