Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add applied_tags parameter to Webhook.send() #2322

Merged
merged 5 commits into from Jan 22, 2024

Conversation

tyrantlink
Copy link
Contributor

Summary

Added applied_tags parameter to Webhook.send(), allowing for forum channel tags to be applied through a webhook.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

discord/webhook/async_.py Outdated Show resolved Hide resolved
discord/webhook/async_.py Outdated Show resolved Hide resolved
discord/webhook/async_.py Outdated Show resolved Hide resolved
discord/webhook/async_.py Outdated Show resolved Hide resolved
discord/webhook/async_.py Outdated Show resolved Hide resolved
@Dorukyum
Copy link
Member

Docs should be fine now, will approve after testing the parameter myself just in case.

Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the parameter should accept a list of ForumTags too to mirror the one in ForumChannel.create_thread. Could use a type of list[Snowflake | ForumTag] and then take IDs from the tag objects.

Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll implement the suggestion I made earlier in a different pull request, thanks.

@Dorukyum Dorukyum merged commit 9422439 into Pycord-Development:master Jan 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants