Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (Sync)WebhookMessage._thread_id could be None #2343

Merged
merged 2 commits into from Feb 1, 2024
Merged

fix: (Sync)WebhookMessage._thread_id could be None #2343

merged 2 commits into from Feb 1, 2024

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Feb 1, 2024 •
edited

Summary

Fixes #2298. ._thread_id is now only set if it's present (i.e. not None).

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Dorukyum Dorukyum added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer labels Feb 1, 2024
@Dorukyum Dorukyum self-assigned this Feb 1, 2024
@Dorukyum Dorukyum requested a review from a team as a code owner February 1, 2024 09:15
@Lulalaby Lulalaby merged commit 7555fc2 into Pycord-Development:master Feb 1, 2024
31 checks passed
@Dorukyum Dorukyum deleted the thread_id branch February 1, 2024 10:02
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Feb 9, 2024
@Dorukyum @OmLanke
fix: (Sync)WebhookMessage._thread_id could be None (Pycord-Develo…
7b836c0 
…pment#2343)

* fix: check if thread_id is None

* chore: add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@Dorukyum Dorukyum

Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError when editing a fetched message from a partial webhook
2 participants
@Dorukyum @Lulalaby