Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing kwargs to TextChannel.create_thread and similar methods #2350

Merged
merged 3 commits into from Feb 3, 2024
Merged

fix: Add missing kwargs to TextChannel.create_thread and similar methods #2350

merged 3 commits into from Feb 3, 2024

Conversation

NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented Feb 3, 2024 •
edited

Summary

Kwargs invitable and slowmode_delay were largely missing from thread creation methods, despite being included elsewhere.
(will test later)

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested a review from a team as a code owner February 3, 2024 19:34
@pullapprove4 pullapprove4 bot requested a review from plun1331 February 3, 2024 19:34
Dorukyum
Dorukyum requested changes Feb 3, 2024
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires testing

@NeloBlivion
Copy link
Member Author

Tested, works as expected.

@Dorukyum Dorukyum merged commit 33cbe88 into Pycord-Development:master Feb 3, 2024
29 of 33 checks passed
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Feb 9, 2024
@NeloBlivion @pre-commit-ci @OmLanke
fix: add missing kwargs to TextChannel.create_thread and similar meth…
e8de840 
…ods (Pycord-Development#2350)

* add missing create_thread kwargs

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix and changelog

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@plun1331 plun1331 Awaiting requested review from plun1331

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeloBlivion @Dorukyum