Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update monetization #2438

Draft
wants to merge 41 commits into
base: master
Choose a base branch
from
Draft

feat: update monetization #2438

wants to merge 41 commits into from
+409 −13

Conversation

plun1331
Copy link
Member

Summary

Implements one time purchases and store changes.

Also fixes some issues that I found while updating.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331 plun1331 requested a review from a team as a code owner April 26, 2024 04:16
@plun1331 plun1331 added upcoming discord feature Involves a feature not yet fully released by Discord feature Implements a feature bug Something isn't working priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Apr 26, 2024
@plun1331 plun1331 self-assigned this Apr 26, 2024
@plun1331 plun1331 added this to the v2.6 milestone Apr 26, 2024
JustaSqu1d
JustaSqu1d suggested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar

CHANGELOG.md Outdated Show resolved Hide resolved
@plun1331 @JustaSqu1d
Update CHANGELOG.md
1d6151f 
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: plun1331 <plun1331@gmail.com>
@plun1331 plun1331 marked this pull request as draft April 26, 2024 14:07
@plun1331
Copy link
Member Author

missing some stuff, will add soon

@plun1331 plun1331 marked this pull request as ready for review April 26, 2024 20:32
@plun1331
Copy link
Member Author

This should be ready to go now, I haven't tested my changes though.

@plun1331
Copy link
Member Author

This is going to be put on hold for updates from discord/discord-api-docs#6875

@plun1331 plun1331 marked this pull request as draft May 16, 2024 19:55
@Dorukyum
Copy link
Member

Status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

At least 1 approving review is required to merge this pull request.

Assignees

@plun1331 plun1331

Labels
bug Something isn't working feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer upcoming discord feature Involves a feature not yet fully released by Discord
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@plun1331 @Dorukyum @JustaSqu1d @Lulalaby