Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update monetization #2438

Merged
merged 52 commits into from
Jun 29, 2024
Merged

feat: update monetization #2438

merged 52 commits into from
Jun 29, 2024

Conversation

plun1331
Copy link
Member

Summary

Implements one time purchases and store changes.

Also fixes some issues that I found while updating.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331 plun1331 requested a review from a team as a code owner April 26, 2024 04:16
@plun1331 plun1331 added upcoming discord feature Involves a feature not yet fully released by Discord feature Implements a feature bug Something isn't working priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Apr 26, 2024
@plun1331 plun1331 self-assigned this Apr 26, 2024
@plun1331 plun1331 added this to the v2.6 milestone Apr 26, 2024
JustaSqu1d
JustaSqu1d suggested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar

CHANGELOG.md Outdated Show resolved Hide resolved
@plun1331 @JustaSqu1d
Update CHANGELOG.md
1d6151f 
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: plun1331 <plun1331@gmail.com>
@plun1331 plun1331 marked this pull request as draft April 26, 2024 14:07
@plun1331
Copy link
Member Author

missing some stuff, will add soon

@Dorukyum
Copy link
Member

Status?

@plun1331 plun1331 marked this pull request as ready for review June 26, 2024 06:21
JustaSqu1d
JustaSqu1d suggested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor doc stuff

discord/client.py Outdated Show resolved Hide resolved
discord/ui/button.py Outdated Show resolved Hide resolved
docs/api/enums.rst Outdated Show resolved Hide resolved
discord/client.py Outdated Show resolved Hide resolved
discord/client.py Outdated Show resolved Hide resolved
discord/client.py Outdated Show resolved Hide resolved
Dorukyum
Dorukyum requested changes Jun 26, 2024
View reviewed changes
discord/client.py Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/client.py Outdated Show resolved Hide resolved
discord/client.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/user.py Outdated Show resolved Hide resolved
discord/user.py Outdated Show resolved Hide resolved
discord/user.py Outdated Show resolved Hide resolved
plun1331 and others added 2 commits June 26, 2024 08:56
@plun1331 @JustaSqu1d @Dorukyum
Apply suggestions from code review
2e74bd9 
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: plun1331 <plun1331@gmail.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
c9e7dd0
Dorukyum
Dorukyum requested changes Jun 28, 2024
View reviewed changes
discord/client.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/user.py Outdated Show resolved Hide resolved
discord/user.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
@Dorukyum
Apply suggestions from code review
2d888fb 
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Dorukyum
Dorukyum requested changes Jun 28, 2024
View reviewed changes
docs/api/enums.rst Outdated Show resolved Hide resolved
docs/api/enums.rst Outdated Show resolved Hide resolved
Dorukyum and others added 4 commits June 28, 2024 19:43
@Dorukyum
Add spacing
9be4fae
@Dorukyum
Add spacing
94e9bfc
@plun1331 @Dorukyum
Apply suggestions from code review
a63f008 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: plun1331 <plun1331@gmail.com>
@plun1331
Merge branch 'master' into upd-monetization
df1bbdb
@plun1331 plun1331 enabled auto-merge (squash) June 28, 2024 20:18
@plun1331 plun1331 requested a review from Dorukyum June 28, 2024 20:18
Dorukyum
Dorukyum requested changes Jun 28, 2024
View reviewed changes
discord/ui/button.py Outdated Show resolved Hide resolved
@Dorukyum
button.py aktualisieren
cd1c70a 
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Dorukyum
Dorukyum approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lgtm

@Dorukyum Dorukyum merged commit abef1ce into Pycord-Development:master Jun 29, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustaSqu1d JustaSqu1d JustaSqu1d requested changes

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

Assignees

@plun1331 plun1331

Labels
bug Something isn't working feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer upcoming discord feature Involves a feature not yet fully released by Discord
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@plun1331 @Dorukyum @JustaSqu1d @Lulalaby