Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove_application_command missing case #2480

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Jun 25, 2024

Summary

The current implementation of CogMixin.remove_application_command ignores the fact that commands with IDs (synchronised commands) stay in the list of pending commands. The new implementation takes this into account.

This intends to fix #1383, requires testing.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Dorukyum Dorukyum added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer changelog needed labels Jun 25, 2024
@Dorukyum Dorukyum added this to the v2.6 milestone Jun 25, 2024
@Dorukyum Dorukyum self-assigned this Jun 25, 2024
@Dorukyum Dorukyum requested a review from plun1331 June 25, 2024 20:45
@Dorukyum Dorukyum marked this pull request as ready for review July 1, 2024 21:45
@Dorukyum Dorukyum requested a review from a team as a code owner July 1, 2024 21:45
@Dorukyum
Copy link
Member Author

Dorukyum commented Jul 1, 2024

Tested and added a changelog entry.

@Lulalaby Lulalaby enabled auto-merge (squash) July 1, 2024 21:54
@Lulalaby Lulalaby merged commit 109a294 into Pycord-Development:master Jul 1, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync_commands() raising Application command names must be unique
2 participants