Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some typing (found with mypy --strict) #252

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Add some typing (found with mypy --strict) #252

merged 2 commits into from
Oct 22, 2021

Conversation

ultrabear
Copy link
Contributor

Summary

Add some typing hints for issues found by mypy --strict
Also make setup.py version regex check for result, found by mypy

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, ...)

@ultrabear
Copy link
Contributor Author

Additional notes:

  • using mypy *.py */*.py */*/*.py --strict --ignore-missing-imports --warn-unreachable mypy reported 1.7k+ issues, I cannot commit to anything but I wish to get these errors down
  • alot of # type: ignore comments have no specific ignore, ex # type: ignore[misc], this leads to ignoring more errors on the same line that may not have wanted to be ignored, I think these should be amended to only ignore specific errors (you can find error codes with --show-error-codes)

@BobDotCom BobDotCom merged commit b014cc0 into Pycord-Development:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants